changeset 61:eed43d1dbdcd

Made all dummy arguments explicitely intent(in), intent(out) or intent(inout) in all routines that I changed already, such that we understand what the function of a routine and arguments is. Compilation and running seems without issues and output looks reasonable in so far a debug run and superficial inspection can tell you.
author Marco van Hulten <marco@hulten.org>
date Wed, 06 Mar 2019 16:35:59 +0100
parents 65d058ddf694
children 314d5bc6a0d9
files mo_sedmnt_offline.F90 powach.F90 read_netcdf_var.F90 sediment_step.F90 write_netcdf_var.F90
diffstat 5 files changed, 16 insertions(+), 12 deletions(-) [+]
line wrap: on
line diff
--- a/mo_sedmnt_offline.F90	Thu Feb 07 13:17:55 2019 +0100
+++ b/mo_sedmnt_offline.F90	Wed Mar 06 16:35:59 2019 +0100
@@ -956,10 +956,11 @@
 
 end subroutine ncwrt_onlysed
 
-subroutine vardef_onlysed(iogrp,timeunits,calendar,cmpflg)
+subroutine vardef_onlysed(iogrp, timeunits, calendar, cmpflg)
 
-integer iogrp,cmpflg
-character timeunits*30,calendar*19
+integer, intent(in)           :: iogrp, cmpflg
+character(len=30), intent(in) :: timeunits
+character(len=19), intent(in) :: calendar
 
 call ncdefvar('time','time',ndouble,0)
 call ncattr('long_name','time')
--- a/powach.F90	Thu Feb 07 13:17:55 2019 +0100
+++ b/powach.F90	Wed Mar 06 16:35:59 2019 +0100
@@ -84,7 +84,7 @@
 
 real, intent(in)     :: pdlxp(kpie,kpje), pdlyp(kpie,kpje)
 real, intent(in)     :: bolay_ (kpie,kpje)
-real, intent(inout)  :: ocetra_(kpie,kpje,nocetra)
+real, intent(in)     :: ocetra_(kpie,kpje,nocetra)
 real, intent(in)     :: keqb_  (11,kpie,kpje)
 real, intent(inout)  :: prorca_(kpie,kpje)
 real, intent(inout)  :: prcaca_(kpie,kpje)
--- a/read_netcdf_var.F90	Thu Feb 07 13:17:55 2019 +0100
+++ b/read_netcdf_var.F90	Wed Mar 06 16:35:59 2019 +0100
@@ -24,13 +24,15 @@
 
 #include <mpif.h>
 
-integer, intent(in) :: ncid, klev, time
+integer, intent(in)          :: ncid, klev, time
+character(len=*), intent(in) :: desc
+real, intent(inout)          :: arr(idm,jdm,klev)
+integer, intent(in)          :: typeio
+
 integer :: ndims
-character(len=*), intent(in) :: desc
-real :: arr(idm,jdm,klev)
 real :: arr_g(itdm,jtdm)
 real, allocatable :: arr_l(:,:)
-integer ncstat, ncvarid, k, i, j, typeio
+integer ncstat, ncvarid, k, i, j
 integer, allocatable :: start(:), count(:) 
 
 ndims = 2
--- a/sediment_step.F90	Thu Feb 07 13:17:55 2019 +0100
+++ b/sediment_step.F90	Wed Mar 06 16:35:59 2019 +0100
@@ -54,7 +54,7 @@
 real, intent(in)     :: psao_  (kpie,kpje)
 real, intent(in)     :: prho_  (kpie,kpje)
 real, intent(in)     :: omask  (kpie,kpje)
-real, intent(inout)  :: ocetra_(kpie,kpje,nocetra)
+real, intent(in)     :: ocetra_(kpie,kpje,nocetra)
 real, intent(in)     :: bolay_ (kpie,kpje)
 real, intent(in)     :: keqb_  (11,kpie,kpje)
 real, intent(inout)  :: prorca_(kpie,kpje)
--- a/write_netcdf_var.F90	Thu Feb 07 13:17:55 2019 +0100
+++ b/write_netcdf_var.F90	Wed Mar 06 16:35:59 2019 +0100
@@ -36,10 +36,11 @@
 
 #include <mpif.h>
 
-integer, intent(in) :: ncid, klev, time
+integer, intent(in)          :: ncid, klev, time
+character(len=*), intent(in) :: desc
+real, intent(inout)          :: arr(idm, jdm, klev)
+
 integer :: ndims
-character(len=*), intent(in) :: desc
-real :: arr(idm,jdm,klev)
 real :: arr_g(itdm,jtdm)
 real, allocatable :: arr_g1(:,:,:), arr_l(:,:)
 integer ncstat, ncvarid, k, i, j